Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Search Editor #91331

Closed
3 tasks done
JacksonKearl opened this issue Feb 25, 2020 · 0 comments
Closed
3 tasks done

Test Search Editor #91331

JacksonKearl opened this issue Feb 25, 2020 · 0 comments

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Feb 25, 2020

Refs: #16488, #23931

Complexity: 3


Search Editors are going GA!

Test:

  • Opening a search editor from existing viewlet results works as expected
  • Opening a new search editor using command pallet works as expected
  • In the search editor:
    • Highlights locations persist across reloads and saving the editor (it is a known issue that they will go away if the editor is closed then reopened)
    • F4 (go to next search result) and Shift+F4 (previous) work
    • Cmd+Shift+L (select all search results) works
  • Overall experience is smooth with large files
  • Extension for writing search result editor changes to workspace works reasonably well: https://marketplace.visualstudio.com/items?itemName=jakearl.search-editor-apply-changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants