Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProtocolDeprecateCallback: The callback argument of protocol module APIs is no longer needed #92138

Closed
bpasero opened this issue Mar 6, 2020 · 1 comment
Closed

ProtocolDeprecateCallback: The callback argument of protocol module APIs is no longer needed #92138

bpasero opened this issue Mar 6, 2020 · 1 comment
Assignees
@mjbvz
Labels
debt Code quality issues
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 6, 2020

Seeing this running our integration tests, I think it originates from

vscode/src/vs/workbench/contrib/webview/electron-browser/webviewProtocols.ts

Line 18 in 811c4b5

contents.session.protocol.registerBufferProtocol(protocol, async (request, callback: any) => {

@mjbvz mjbvz added the debt Code quality issues label Mar 6, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 6, 2020

https://www.electronjs.org/docs/api/breaking-changes-ns#planned-breaking-api-changes

@mjbvz mjbvz added this to the March 2020 milestone Mar 6, 2020
@mjbvz mjbvz closed this as completed in 4270786 Mar 6, 2020
@mjbvz mjbvz mentioned this issue Mar 26, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @mjbvz