-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Files to include" in search does not search for all partial matches #92559
Comments
I don't think that is true. It has always required a glob star to match your example, at least that is the way it is intended to work. |
You're right, it seems it required stars for all cases. Currently search works for me really unreliably, sometimes results appear to change once I search again after few another searches. Examples: Test file tree, each contains
Values I search for in order:
|
It seems likely that simple.ts is open, in which case it will be searched anyway even if it doesn't match. Is that the case? There is another bug on this. |
So in conclusion, for closed files search works as expected (using glob), but for opened files include filter is flawed and seems to be matched when any element on the path ends with the include filter (see Should I close this ticket and open a new one with cleaner description? Thank you for helping with specifying what's exactly wrong with this one. |
Simpler than that, open files are always searched. There is already an open issue for it: #31819 |
Issue Type: Bug
*ries*
if searching forfactories
In previous releases any substring was accepted, so it appears to be regression.
VS Code version: Code 1.43.0 (78a4c91, 2020-03-09T19:44:52.965Z)
OS version: Linux x64 5.0.0-38-generic
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off_ok
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Extensions (11)
(1 theme extensions excluded)
The text was updated successfully, but these errors were encountered: