Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for dynamic views #92590

Closed
miguelsolorio opened this issue Mar 12, 2020 · 8 comments
Closed

Icons for dynamic views #92590

miguelsolorio opened this issue Mar 12, 2020 · 8 comments
Assignees
Labels
icons-product Issues for in-product icons workbench-views Workbench view issues
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Overview

This issue is to identify what icons we use for dynamic sidebar views. Views can be moved into the panel, sidebar, and activity bar. When views are in the activity bar, we'll need to decide which icons we use and what the default is when there are no icons defined (extensions will be able to define a custom icon).

Out of scope

Allowing users to select an icon

Current Proposal

image

@miguelsolorio miguelsolorio added workbench-views Workbench view issues icons-product Issues for in-product icons labels Mar 12, 2020
@miguelsolorio miguelsolorio added this to the March 2020 milestone Mar 12, 2020
@miguelsolorio miguelsolorio self-assigned this Mar 12, 2020
@miguelsolorio
Copy link
Contributor Author

Feedback from the Redmond team:

  1. Problems ✅
  2. Output: first icon is preferred
  3. Debug console ✅
  4. Terminal ✅
  5. Custom Views: indifferent, last one looks similar to extension icon (might cause confusion?)

@Tyriar
Copy link
Member

Tyriar commented Mar 17, 2020

@misolori some thoughts:

  • Output: First one says clipboard to me, I prefer the second as it kind of communicates (log) book. Still not the strongest association though.
  • Terminal: Could we try a box outline similar to debug console as well to see how that looks?
  • Custom views: First one means package or method to me, we also already use it
    Screen Shot 2020-03-17 at 2 16 14 PM

@miguelsolorio
Copy link
Contributor Author

miguelsolorio commented Mar 17, 2020

@Tyriar here's the console version for comparison and a few others for custom views:

image

@miguelsolorio
Copy link
Contributor Author

Here's the proposed icons after the last round of feedback:

image

@Tyriar
Copy link
Member

Tyriar commented Mar 24, 2020

@misolori looks fantastic!

By the way this is what I was trying to describe as an alternative for custom views:

image

The view would show the first for 1 view, second for 2 and third for 3+. If there ended up being a bunch of these then it might be easier to differentiate? Might also be trying to solve a problem that doesn't exist 😄

@miguelsolorio
Copy link
Contributor Author

I like that idea, but I agree that it might be a bit overkill (esp. if you have lots of views w/ more than 3). I do like the "dynamicness" of the icon though 👌

@regs01
Copy link

regs01 commented Apr 7, 2020

Most important icon is missed - Outline

@miguelsolorio
Copy link
Contributor Author

@regs01 please see #93964 (comment)

@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
icons-product Issues for in-product icons workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

3 participants