Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Terminal link handler API #93596

Closed
3 tasks done
Tyriar opened this issue Mar 27, 2020 · 4 comments
Closed
3 tasks done

Test: Terminal link handler API #93596

Tyriar opened this issue Mar 27, 2020 · 4 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 27, 2020

Refs: #91606

Complexity: 2


There is a new extension API that enables listening for clicks on terminal links and handling them from an extension. To test, scaffold out an extension and try out the new API and validate its documentation.

This is likely to finalize next iteration.

@roblourens
Copy link
Member

I'm curious what the Terminal object would be used for, which implementor will do something different depending on which terminal the link was clicked in?

@JacksonKearl
Copy link
Contributor

Seems to work fine. Assuming extensions providing link detectors is somewhere on the backlog?

@JacksonKearl JacksonKearl removed their assignment Mar 31, 2020
@connor4312
Copy link
Member

which implementor will do something different depending on which terminal the link was clicked in

In js-debug we only handle links that come from the debug temrinal

@Tyriar
Copy link
Member Author

Tyriar commented Mar 31, 2020

@JacksonKearl yes but it's blocked on adopting an early xterm.js API and not sure about the priority relative to everything else. #91290

@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants