Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol icons could be so much more helpful #94263

Closed
matklad opened this issue Apr 2, 2020 · 11 comments
Closed

Symbol icons could be so much more helpful #94263

matklad opened this issue Apr 2, 2020 · 11 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@matklad
Copy link

matklad commented Apr 2, 2020

I've been using VS Code extensively for more than a year now, and I must say I still don't know the meaning of symbol icons:

VS_icons

IE, the only useful info that these icons convey me is that some symbols are of different kind.

In contrast, IntelliJ's much simpler icons have a very clear meaning, even if you haven't used IntelliJ a lot:

IJ_icons

f is field, C is class, m is method, E is enum, etc...

I wish VS Code used such letter mnemonic scheme as well, it seems more useful for new and expert users alike.

https://www.jetbrains.com/help/idea/symbols.html#
https://www.jetbrains.com/help/clion/icons-and-symbols.html#

@miguelsolorio
Copy link
Contributor

These icons come from Visual Studio and we've had them from the beginning. I understand that some icons might not be useful/meaningful, but we are currently working on allowing extensions to provide their own custom icons to use throughout VS Code (see #92791) and I think this will help address this issue. Icons are subjective and what works for you might not work for others (and vice versa).

@matklad
Copy link
Author

matklad commented Apr 2, 2020

Subscribed to #92791, I believe it indeed can solve this issue in practice, thanks!

Still, I'd like to push back a little against

Icons are subjective and what works for you might not work for others

This is undoubtedly true, but I feel there's a meaningful fundamental difference between purely graphical icons, and mnemonics-based icons. And my gut feeling tells that significantly more people will intuitively understand mnemonics-based one. Which, naturally, doesn't mean that this benefit outweighs, eg, the benefits of not changing anything.

@miguelsolorio
Copy link
Contributor

Which, naturally, doesn't mean that this benefit outweighs, eg, the benefits of not changing anything.

This will likely be the biggest hurdle to changing the default. A good majority of users switch between VS and VS Code and this continuity is highly appreciated. So if the default ever changed it would affect a large majority. That's not to say we'd never change it, last year we did a major icon overhaul that diverged from VS. But I honestly don't see us changing the default for symbol icons and is why we're open to allowing to change all the icons based on user preference.

@jrieken any thoughts?

@jrieken
Copy link
Member

jrieken commented Apr 2, 2020

I understand both side - I can also not "understand" those icons but see that folks are used to them, likely for decades. Therefore I am also a little afraid to change the default, but we could ship an alternative, more logical, set out of the box and encourage users to try it. Personally, I have solved this problem like so: "editor.suggest.showIcons": false

@kjeremy
Copy link

kjeremy commented Apr 4, 2020

The two concepts could always be combined. A small offset letter may be a nice complement to the current icon set.

@miguelsolorio
Copy link
Contributor

I'll leave this up and see what the community thinks, will mark this as a backlog candidate.

@miguelsolorio miguelsolorio added this to the Backlog Candidates milestone Apr 6, 2020
@shba007
Copy link

shba007 commented Apr 7, 2020

Definitely it will help

@eternalblue
Copy link

I'll make a poorly sourced estimate that most of the users that use VSCode never or at least not continuously used Visual Studio; it will be great to have a default set (the current ones) and a more mnemonic set of icons as alternative.

@miguelsolorio miguelsolorio added the feature-request Request for new features or functionality label Aug 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

7 participants
@matklad @jrieken @kjeremy @miguelsolorio @shba007 @eternalblue and others