Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no hotkey scrolling if //#region is collapsed #94470

Closed
LexRiver opened this issue Apr 5, 2020 · 8 comments
Closed

no hotkey scrolling if //#region is collapsed #94470

LexRiver opened this issue Apr 5, 2020 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-commands Editor text manipulation commands *out-of-scope Posted issue is not in scope of VS Code

Comments

@LexRiver
Copy link

LexRiver commented Apr 5, 2020

Issue Type: Bug

if I have a collapsed region in my .ts file

        //#region some region
        if(true){
            void 0
        }
        //#endregion

then when I try to scroll with my keyboard ctrl+down I'm unable to scroll lower than first line of my collapsed region. So when region becomes the first line I'm unable to scroll any lower.

ctrl+up works fine
if the region is not collapsed then scrolling works correctly

VS Code version: Code 1.43.2 (0ba0ca5, 2020-03-24T07:38:38.248Z)
OS version: Windows_NT x64 10.0.18362

System Info
Item Value
CPUs Intel(R) Core(TM) i7-3820 CPU @ 3.60GHz (8 x 3611)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.98GB (4.84GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (40)
Extension Author (truncated) Version
numbered-bookmarks ale 7.0.0
vscode-color ans 0.4.5
vscode-intelephense-client bme 1.3.11
vscode-css-modules cli 0.2.3
jsrefactor cms 2.20.5
vscode-simpler-icons dav 1.6.5
vscode-eslint dba 2.1.2
vscode-style-formatter dwe 1.0.0
vscode-great-icons emm 2.1.47
vsc-material-theme Equ 32.5.0
vsc-material-theme-icons equ 1.1.4
prettier-vscode esb 4.0.0
vscode-commands fab 1.3.0
php-intellisense fel 2.3.14
file-icons fil 1.0.23
vscode-svelte-snippets fiv 0.3.0
auto-rename-tag for 0.1.1
gc-excelviewer Gra 2.1.34
path-autocomplete ion 1.13.6
easy-icons jam 0.3.1
vscode-icon-theme jtl 1.6.6
vscode-colorize kam 0.8.16
Lua key 0.0.9
vscode-simple-icons Lau 1.13.2
vscode-deploy-reloaded mkl 0.89.0
theme-monokai-pro-vscode mon 1.1.15
vscode-scss mrm 0.9.0
debugger-for-chrome msj 4.12.6
material-icon-theme PKi 4.0.1
seti-icons qin 0.1.3
sass-indented rob 1.5.1
code-settings-sync Sha 3.4.3
lua sum 0.16.2
ayu tea 0.18.0
vscode-lua tri 0.12.4
vscode-counter uct 1.3.4
es-quotes vil 0.2.6
vscode-todo-highlight way 1.0.4
change-case wma 1.0.0
material-theme zhu 3.2.5

(27 theme extensions excluded)

We have written the needed data into your clipboard because it was too large to send. Please paste.
@vscodebot
Copy link

vscodebot bot commented Apr 5, 2020

@aeschli aeschli assigned alexdima and unassigned aeschli Apr 6, 2020
@alexdima
Copy link
Member

alexdima commented Apr 7, 2020

@LexRiver Does this reproduce when disabling all extensions? (I am asking because extensions can override keybindings).

@alexdima alexdima added the info-needed Issue requires more information from poster label Apr 7, 2020
@LexRiver
Copy link
Author

LexRiver commented Apr 7, 2020

@alexdima yes, just checked

also maybe you could fix this small bug with //#region autocompletion

if I type //#re and then press Tab to autocomplete I'm getting ////#region instead of //#region

@alexdima
Copy link
Member

@LexRiver Please keep each issue focused on one issue. If you have another issue with Tab autocomplete, then please create a separate issue.

By default, ctrl+down is bound to scrollLineDown on Windows. When I try the command around a folded region, it works fine for me:

Kapture 2020-04-24 at 14 27 09

Do you have additional steps to help us reproduce the problem?

@LexRiver
Copy link
Author

LexRiver commented Apr 24, 2020

@alexdima seems like this bug appears only if I have the following lines in my keybindings.json

{
    "key": "ctrl+up",
    "command": "editorScroll",
    "args": {"to":"up", "by":"line", "value": 3, "revealCursor": true},
    "when": "textInputFocus"
},
{
    "key": "ctrl+down",
    "command": "editorScroll",
    "args": {"to": "down", "by":"line", "value": 3, "revealCursor": true},
    "when": "textInputFocus"
}

@alexdima
Copy link
Member

@LexRiver Thanks for following up. A workaround would be to use:

{
    "key": "ctrl+up",
    "command": "editorScroll",
    "args": {"to":"up", "by":"wrappedLine", "value": 3, "revealCursor": true},
    "when": "textInputFocus"
},
{
    "key": "ctrl+down",
    "command": "editorScroll",
    "args": {"to": "down", "by":"wrappedLine", "value": 3, "revealCursor": true},
    "when": "textInputFocus"
}

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug editor-commands Editor text manipulation commands and removed info-needed Issue requires more information from poster labels Apr 27, 2020
@LexRiver
Copy link
Author

@alexdima that works, thanks

@alexdima alexdima added the *out-of-scope Posted issue is not in scope of VS Code label Dec 10, 2022
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-commands Editor text manipulation commands *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

4 participants