Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search editor - Remember recent filter regexes #95420

Closed
chavlji opened this issue Apr 16, 2020 · 8 comments
Closed

Search editor - Remember recent filter regexes #95420

chavlji opened this issue Apr 16, 2020 · 8 comments
Assignees

Comments

@chavlji
Copy link

chavlji commented Apr 16, 2020

Search inside editor is an awesome feature!

It would, however, be much more useful with that small tweaks:

  • remember state (show/hidden) of Search details panel
  • remember the last content of fields files to include and files to exclude
  • remember recent file filters

Sublime does all of this very good and I've used it all the time:
Screenshot 2020-04-16 at 09 55 26

@gjsjohnmurray
Copy link
Contributor

Are you aware that cursor-up in these fields can recall previous entries?

@roblourens
Copy link
Member

You can navigate history with the arrow keys like @gjsjohnmurray points out

@chavlji
Copy link
Author

chavlji commented Apr 16, 2020

Nope, it doesn't work in these fields. I'm using the latest insider version.

Besides don't just close it. Even if it would work it would only answer my 3rd point. What about the 1st and 2nd?

@roblourens
Copy link
Member

  1. The state is remembered per workspace. Can you give some more details about where you are not seeing that work?
  2. The arrow keys
  3. Can you explain what you mean by file filters?

@roblourens roblourens reopened this Apr 16, 2020
@chavlji
Copy link
Author

chavlji commented Apr 16, 2020

Sure. Thanks for reopening!

I press cmd+shift+f and set the search like this:
Screenshot 2020-04-16 at 20 27 10

I close the search tab.
Press cmd+shift+fagain and all fields are reset:

Screenshot 2020-04-16 at 20 27 35

How it should be
imo when I reopen it, it should look like where I've left it:

  • search filed filled with previous string ('target')
  • search details opened
  • files to include/exclude filled with previous filters:

Screenshot 2020-04-16 at 20 38 15

It seems like a minor issue but It's very cumbersome when you work on a large new project and you have to search a lot...

* Up/down arrows do work - thanks for the hint. But it would be nice if I wouldn't have to focus fields all the time and pressing arrow keys to restore the state...

@JacksonKearl
Copy link
Contributor

Please try out "search.searchEditor.experimental.reusePriorSearchConfiguration": true in Insiders and let me know what you think.

Its a hidden setting, you'll have to enter it into settings.json manually.

@chavlji
Copy link
Author

chavlji commented Apr 20, 2020

What do I think? I love it!!!

Thank you @JacksonKearl !

Also... imo it should be the default behavior. More times the user would want app to remember state than not.

@JacksonKearl
Copy link
Contributor

Discussing options for the future in #89353

@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants