Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal: Improve environment variable collection popup #96250

Closed
joaomoreno opened this issue Apr 27, 2020 · 6 comments
Closed

Terminal: Improve environment variable collection popup #96250

joaomoreno opened this issue Apr 27, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 27, 2020

This can get pretty verbose quickly:

image

Also, should we indicate which extension is doing which changes?

@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2020

Might be better:

Extensions have made changes to this terminal's environment:

VSCODE_GIT_IPC_HANDLE=/tmp/vscode-git-ipc-blah...
FOO=${env:FOO}BAR
BAR=FOO${env:BAR}

Using a code block and not wrap it just like in the editor?

@Tyriar Tyriar added terminal General terminal issues that don't fall under another label polish Cleanup and polish issue labels Apr 27, 2020
@Tyriar Tyriar added this to the April 2020 milestone Apr 27, 2020
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 29, 2020

image

(this one now doesn't show by default #96574)

image

@Tyriar Tyriar closed this as completed in 151c443 Apr 29, 2020
@joaomoreno
Copy link
Member Author

Also, should we indicate which extension is doing which changes?

☝️

@Tyriar
Copy link
Member

Tyriar commented Apr 30, 2020

👉 #96699

@joaomoreno
Copy link
Member Author

@Tyriar The icon seems to be gone today:

image

@Tyriar
Copy link
Member

Tyriar commented Apr 30, 2020

Only the warning shows by default now as basically every terminal will have it now due to git using the API. Use "terminal.integrated.environmentChangesIndicator": "on"

@mjbvz mjbvz added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants