Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused Let and Used Const too similar in typescript with the new Semantic Token Color Customization default colours #97784

Closed
David-Tennant opened this issue May 14, 2020 · 2 comments
Assignees

Comments

@David-Tennant
Copy link

  • VSCode Version: 1.45.0
  • OS Version: Microsoft Windows 10 Pro, 10.0.183363 Build 18363

Issue:

Steps to Reproduce:

  1. Use theme "Dark+" aka "default dark"
  2. Create a typescript file with used and unused consts and lets

Does this issue occur when all extensions are disabled?: Yes

Thanks for the new colorization. Unfortunately, the color of a used const looks very similar to the color of an unused let especially when you have underlining messing with the view of the colors

With underlining:

image

Without underlining:

image

I have tried tweaking the colors but haven't found a comfortable color yet. Hence an issue without a PR haha. Thanks again for the feature its quite nice

@mattacosta
Copy link
Contributor

Duplicate of #95346.

If you want the old colors back, you can add this to your settings:

"editor.tokenColorCustomizations": {
    "[Default Dark+]": {
        "textMateRules": [
            {
                "scope": ["variable.other.constant", "variable.other.enummember"],
                "settings": {
                    "foreground": "#9CDCFE"
                }
            }
        ]
    },
}

@David-Tennant
Copy link
Author

Duplicate of #95346.

I will be closing this now. Thanks, @mattacosta for finding the other issue. I didnt see it

@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants