Downgrade externals - tests for test platform nuget #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhnaseer
approved these changes
Nov 23, 2020
cvpoienaru
approved these changes
Nov 23, 2020
test/Microsoft.TestPlatform.AcceptanceTests/TestPlatformNugetPackageTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/TestPlatformNugetPackageTests.cs
Outdated
Show resolved
Hide resolved
|
Could you fix the description, please? I don't understand what was this meant to do. And would like to know in the future, if it is identified in some regression. |
|
Hello @cvpoienaru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Done |
This was referenced Mar 6, 2021
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found out that TraceDataCollector depends on Coverage.Interop.dll so previous deletion of Coverage.Interop.dll results in not be able to get code coverage. This was detected by manual test. PR is also adding automatic test to check TP + TraceDataCollector (from VS) integration.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.