Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS minimum version numbers are unreliable #1341

Closed
timsneath opened this issue Oct 29, 2022 · 4 comments
Closed

OS minimum version numbers are unreliable #1341

timsneath opened this issue Oct 29, 2022 · 4 comments

Comments

@timsneath
Copy link
Contributor

I'd love to be able to trust the value of SupportedOSPlatform, but currently the data appears dangerously (!) inaccurate. This is super-hard, I know, but it would be better to not have it in the metadata than have unreliable data.

Some examples:

Function Documented minVer Metadata minVer
winsock functions Windows Vista 8.1
ClosePseudoConsole and other
modern console functions
17763 none
GetDisplayAutoRotationPreferences Windows 8.0 none
GetMachineTypeAttributes 22000 none
GetTempPath2 20348 none
IsWow64Process2 10586 16299
@riverar
Copy link
Collaborator

riverar commented Oct 31, 2022

Yeah most of the values are wrong. You should completely ignore this attribute until a major overhaul is completed.

@riverar
Copy link
Collaborator

riverar commented Oct 31, 2022

Will close this for #738. If you believe that's in error, just holler!

@riverar riverar closed this as completed Oct 31, 2022
@riverar riverar closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2022
@timsneath
Copy link
Contributor Author

I think we should either document that it's unreliable, or (preferably) remove the field from the database until it has some modicum of accuracy.

(FWIW, I wasted an afternoon implementing this in my Dart projection instead of my artisanally handcrafted values before I realized that it was a retrograde step.)

@riverar
Copy link
Collaborator

riverar commented Oct 31, 2022

Agreed, and sorry! ☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants