Bug: SetThreadErrorMode has invalid prototype

[vthib]

Which crate is this about?

windows-sys

Crate version

0.45.0

Summary

The SetThreadErrorMode function has this prototype: https://docs.rs/windows-sys/0.45.0/windows_sys/Win32/System/Diagnostics/Debug/fn.SetThreadErrorMode.html

pub unsafe extern "system" fn SetThreadErrorMode(
    dwnewmode: THREAD_ERROR_MODE,
    lpoldmode: *const THREAD_ERROR_MODE
) -> BOOL

But as seen in the official doc: https://learn.microsoft.com/en-us/windows/win32/api/errhandlingapi/nf-errhandlingapi-setthreaderrormode the "lpoldmode" is an out parameter, and thus should be a *mut THREAD_ERROR_MODE.

[riverar]

Yep, metadata bug, sorry about that. Transferring over there.

[kennykerr]

This function is declared as follows:

WINBASEAPI
BOOL
WINAPI
SetThreadErrorMode(
    _In_ DWORD dwNewMode,
    _In_opt_ LPDWORD lpOldMode
    );

The SAL annotation is wrong - it should be: _Out_opt_