Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zip] Nested Installer Files Validation #2523

Closed
Trenly opened this issue Sep 17, 2022 · 7 comments · Fixed by #2500
Closed

[Zip] Nested Installer Files Validation #2523

Trenly opened this issue Sep 17, 2022 · 7 comments · Fixed by #2500
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@Trenly
Copy link
Contributor

Trenly commented Sep 17, 2022

  • Non-Portable Installer Type doesn't warn when PortableCommandAlias is included for a NestedInstallerFile

Note: The below items are likely not implemented yet, as Portable support hasn't been implemented for Zip files yet. I'm placing them here as a consideration to ensure they are validated against

  • Portable Installer Type doesn't throw an error when two entries have the same RelativeFilePath
    • This might be acceptable as long as they have different command aliases?
  • Portable Installer Type doesn't throw an error when two entries have the same PortableCommandAlias
@ghost ghost added the Needs-Triage Issue need to be triaged label Sep 17, 2022
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Sep 19, 2022
@denelon
Copy link
Contributor

denelon commented Sep 19, 2022

@ryfu-msft please take a look at this.

@ryfu-msft
Copy link
Contributor

Thanks for catching this, additional validation will be added in #2500

@ghost ghost added the In-PR Issue related to a PR label Sep 27, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Sep 27, 2022
@denelon denelon added this to the v1.4-Client milestone Nov 22, 2022
@sitiom
Copy link

sitiom commented Jan 26, 2023

  • This might be acceptable as long as they have different command aliases?

Seems like this isn't implemented: microsoft/winget-pkgs#94699 (comment)

@denelon
Copy link
Contributor

denelon commented Jan 26, 2023

This version isn't in the validation pipelines yet. We're waiting for the 1.4 client rollout to the majority of users. We want to avoid as much confusion as possible with the "winget" source having .zip-based packages they can't install with earlier versions of winget.

@sitiom
Copy link

sitiom commented Jan 26, 2023

What I mean is that winget validate fails locally and that an exception should be made for the same RelativeFilePath but different PortableCommandAlias.

@denelon
Copy link
Contributor

denelon commented Jan 26, 2023

@sitiom can you create a new issue with an example?

@sitiom
Copy link

sitiom commented Jan 26, 2023

#2884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants