Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switches are case sensitive #252

Closed
Trenly opened this issue Apr 6, 2022 · 0 comments · Fixed by #256
Closed

Switches are case sensitive #252

Trenly opened this issue Apr 6, 2022 · 0 comments · Fixed by #256

Comments

@Trenly
Copy link
Contributor

Trenly commented Apr 6, 2022

Brief description of your issue

When using the switches --Urls and --Version are not accepted, but --urls and --version are

Steps to reproduce

wingetcreate update SmartSoft.SmartFTP --Version 10.0.2950.0 --Urls https://static.smartftp.com/static/Products/Client/10.0.2950.0/x64/SmartFTP.msi

Expected behavior

Manifest upgrades successfully

Actual behavior

wingetcreate update SmartSoft.SmartFTP --Version 10.0.2950.0 --Urls https://static.smartftp.com/static/Products/Client/10.0.2950.0/x64/SmartFTP.msi
Windows Package Manager Manifest Creator v1.0.3.0

Copyright (c) Microsoft Corporation. All rights reserved.

The manifest creation command line utility generates manifest for submitting
apps to the Windows Package Manager repo.

USAGE:
Search for an existing manifest and update the installer url and version:
  wingetcreate.exe update --urls <InstallerUrl1> <InstallerUrl2> --version <Version>
  <PackageIdentifier>
Save and publish updated manifest:
  wingetcreate.exe update --out <OutputDirectory> --token <GitHubPersonalAccessToken> --version
  <Version> <PackageIdentifier>
Override the architecture of an installer:
  wingetcreate.exe update --urls <InstallerUrl1>|<InstallerArchitecture> --version <Version>
  <PackageIdentifier>

  -v, --version                 Version to be used when updating the package version field.
  -o, --out                     Output directory where the newly created manifests will be saved
                                locally
  -s, --submit                  Boolean value for submitting to the Windows Package Manager repo. If
                                true, updated manifest will be submitted directly using the provided
                                GitHub Token. Default is false.
  -i, --interactive             Boolean value for making the update command interactive. If true,
                                the tool will prompt the user for input. Default is false.
  -t, --token                   GitHub personal access token used for direct submission to the
                                Windows Package Manager repo. If no token is provided, tool will
                                prompt for GitHub login credentials.
  -u, --urls                    Installer Url(s) used to extract relevant metadata for generating a
                                manifest
  PackageIdentifier (pos. 0)    Required. Package identifier used to lookup the existing manifest on
                                the Windows Package Manager repo. Id is case-sensitive.

More help can be found at: https://aka.ms/winget-create
Privacy statement: https://aka.ms/privacy

 Option 'Version' is unknown.
 Option 'Urls' is unknown.

Environment

PS D:\Git\winget-pkgs> winget --info
Windows Package Manager (Preview) v1.3.431-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19043.1586
Package: Microsoft.DesktopAppInstaller v1.18.431.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
PS D:\Git\winget-pkgs> winget list wingetcreate
Name                                     Id                     Version
-----------------------------------------------------------------------
Windows Package Manager Manifest Creator Microsoft.WingetCreate 1.0.3.0
PS D:\Git\winget-pkgs>
@ghost ghost added the Needs-Triage label Apr 6, 2022
@ghost ghost added the In-PR label Apr 9, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants