Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget failing to install silently with --silent #133505

Closed
PckgrBot opened this issue Jan 9, 2024 · 7 comments
Closed

Winget failing to install silently with --silent #133505

PckgrBot opened this issue Jan 9, 2024 · 7 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@PckgrBot
Copy link
Contributor

PckgrBot commented Jan 9, 2024

Brief description of your issue

When installing application Krisp using the --silent command it actually launches the instllaer GUI. Interesting when I remove the --silent command it installs silently. I think I noticed this happen with another application too.

image

Steps to reproduce

winget install krisp.krisp --silent

Expected behavior

Application should install silently.

Actual behavior

Application shows GUI to install.

Environment

Windows Package Manager v1.6.3482
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.2861
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.21.3482.0
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Jan 9, 2024
@denelon denelon transferred this issue from microsoft/winget-cli Jan 10, 2024
@denelon
Copy link
Contributor

denelon commented Jan 10, 2024

This is likely due to the switches in the manifest or the installer itself.

@denelon
Copy link
Contributor

denelon commented Jan 10, 2024

It's an inno based installer. When I pass "-?" to the installer I see:

Krisp

@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Jan 10, 2024
@denelon
Copy link
Contributor

denelon commented Jan 10, 2024

WinGet was passing in:

2024-01-09 16:35:59.604 [CLI ] Installer args: /VERYSILENT /NORESTART /LOG="C:\Users\denelon\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-Krisp.Krisp.2.24.5-2024-01-09-16-35-59.604.log"
2024-01-09 16:35:59.605 [CLI ] Starting: 'C:\Users\denelon\AppData\Local\Temp\WinGet\Krisp.Krisp.2.24.5\Krisp_2.24.5.exe' with arguments '/VERYSILENT /NORESTART /LOG="C:\Users\denelon\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir\WinGet-Krisp.Krisp.2.24.5-2024-01-09-16-35-59.604.log"'

I'm guessing /VERYSILENT is the default for INNO, but this package is expecting /quiet.

The manifest might be able to be updated so silent passes in "/quiet" rather than the default value.

@Dragon1573
Copy link
Contributor

There's a new version waiting for approval to be merged. I think we can update the manifest there.

@Exorcism0666
Copy link
Contributor

@PckgrBot you can close this issue.

@PckgrBot
Copy link
Contributor Author

Thanks for the help everyone!

@Exorcism0666
Copy link
Contributor

No problem!

@denelon denelon added this to the 1.7 Packages milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

4 participants