-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: agenda tooltip with keyboard focus #2621
Conversation
add a tab stop to titles in agenda events with tooltips closes #2236
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
The updated storybook is available here |
@vagpt could you please test this fix |
Hi @gavinbarron, This issue is partially fixed as in current Tooltip is appearing, but it appears when keyboard focus is landing on non-interactive element i.e. 'Lunch or Friday Unwinder'. So it is not properly fixed as both are non-interactive elements. So as per the expected Tooltip should be as soon as keyboard focus entirely lands on the 12:30 AM- 1:30 AM section. Attachment: MGTP.-.Partially.fixed.mp4 |
@vagpt as outlined in the related issue we cannot trigger the tooltip based on focus of the card, it's simply NOT acheivable with the set of components being used At this point I propose we remove the tooltip completely @sebastienlevert, thoughts? |
Agree @gavinbarron. Let's remove it as anyways it conveys partial information. |
@vagpt we've removed the tooltip as there is no solution that looked good for what was a low quality feature |
The updated storybook is available here |
@gavinbarron and @sebastienlevert Now, there is no tooltip appearing as per your above comment so we are good to close this issue. |
The updated storybook is available here |
closes #2236
PR Type
Description of the changes
add a tab stop to titles in agenda events with tooltip
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information