Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: agenda tooltip with keyboard focus #2621

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

gavinbarron
Copy link
Member

closes #2236

PR Type

  • Bugfix

Description of the changes

add a tab stop to titles in agenda events with tooltip

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • Accessibility tested and approved
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

add a tab stop to titles in agenda events with tooltips
closes #2236
@gavinbarron gavinbarron requested a review from a team as a code owner July 19, 2023 22:11
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

musale
musale previously approved these changes Jul 20, 2023
@github-actions
Copy link

The updated storybook is available here

@gavinbarron
Copy link
Member Author

@vagpt could you please test this fix

@vagpt
Copy link
Collaborator

vagpt commented Jul 21, 2023

Hi @gavinbarron,

This issue is partially fixed as in current Tooltip is appearing, but it appears when keyboard focus is landing on non-interactive element i.e. 'Lunch or Friday Unwinder'. So it is not properly fixed as both are non-interactive elements.

So as per the expected Tooltip should be as soon as keyboard focus entirely lands on the 12:30 AM- 1:30 AM section.

Attachment:

MGTP.-.Partially.fixed.mp4

@gavinbarron
Copy link
Member Author

@vagpt as outlined in the related issue we cannot trigger the tooltip based on focus of the card, it's simply NOT acheivable with the set of components being used

At this point I propose we remove the tooltip completely @sebastienlevert, thoughts?

@sebastienlevert
Copy link
Contributor

Agree @gavinbarron. Let's remove it as anyways it conveys partial information.

@gavinbarron
Copy link
Member Author

@vagpt we've removed the tooltip as there is no solution that looked good for what was a low quality feature

@github-actions
Copy link

The updated storybook is available here

@vagpt
Copy link
Collaborator

vagpt commented Jul 28, 2023

@gavinbarron and @sebastienlevert

Now, there is no tooltip appearing as per your above comment so we are good to close this issue.

@gavinbarron gavinbarron merged commit 27e1fc9 into main Jul 28, 2023
7 checks passed
@gavinbarron gavinbarron deleted the fix/agenda-tooltip branch July 28, 2023 08:34
@github-actions
Copy link

The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants