fix: add a title text if displaying images only. #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
|
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
|
The updated storybook is available here |
1 similar comment
|
The updated storybook is available here |
gavinbarron
requested changes
Jul 24, 2023
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
|
The updated storybook is available here |
…kit into bug-2201
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
|
The updated storybook is available here |
Mnickii
previously approved these changes
Jul 25, 2023
gavinbarron
requested changes
Jul 25, 2023
packages/mgt-components/src/components/mgt-person/mgt-person.ts
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
|
The updated storybook is available here |
…kit into bug-2201
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
|
The updated storybook is available here |
gavinbarron
approved these changes
Jul 27, 2023
|
The updated storybook is available here |
gavinbarron
added a commit
that referenced
this pull request
Aug 21, 2023
add a title attribute if displaying profile avatar/initials. --------- Signed-off-by: Martin Musale <martinmusale@microsoft.com> Co-authored-by: Nickii Miaro <miaronkirote@gmail.com> Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2201
PR Type
Description of the changes
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information