-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add show-presence to mgt-people-picker #2812
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add show-presence attribute to mgt-people-picker BREAKING CHANGE: this changes the default behavior of mgt-people-picker to not show presence
gavinbarron
changed the title
feat: add show-presence to mgt-people-picker
feat!: add show-presence to mgt-people-picker
Oct 30, 2023
musale
approved these changes
Oct 31, 2023
sebastienlevert
approved these changes
Oct 31, 2023
|
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2794
PR Type
Description of the changes
add show-presence attribute to mgt-people-picker
BREAKING CHANGE: this changes the default behavior of mgt-people-picker to not show presence
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information
Impact of breaking change is that now people picker usages will not show presence by default.
BEGIN_COMMIT_OVERRIDE
feat!: add show-presence to mgt-people-picker (#2812)
adds show-presence attribute to mgt-people-picker
BREAKING CHANGE: default behavior of mgt-people-picker changes so presence is not shown unless show-presence attribute or showPresence property are set
END_COMMIT_OVERRIDE