Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add show-presence to mgt-people-picker #2812

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Oct 30, 2023

Closes #2794

PR Type

  • Feature

Description of the changes

add show-presence attribute to mgt-people-picker

BREAKING CHANGE: this changes the default behavior of mgt-people-picker to not show presence

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Impact of breaking change is that now people picker usages will not show presence by default.

BEGIN_COMMIT_OVERRIDE
feat!: add show-presence to mgt-people-picker (#2812)

adds show-presence attribute to mgt-people-picker

BREAKING CHANGE: default behavior of mgt-people-picker changes so presence is not shown unless show-presence attribute or showPresence property are set
END_COMMIT_OVERRIDE

add show-presence attribute to mgt-people-picker

BREAKING CHANGE: this changes the default behavior of mgt-people-picker to not show presence
@gavinbarron gavinbarron requested a review from a team as a code owner October 30, 2023 22:45
@gavinbarron gavinbarron changed the title feat: add show-presence to mgt-people-picker feat!: add show-presence to mgt-people-picker Oct 30, 2023
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 80% 100% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 65% 0
mgt-components.src.components.mgt-person-card 62% 41% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 78% 20% 0
mgt-element.dist.es6.components.src.components 73% 80% 0
mgt-element.dist.es6.mock.src.mock 90% 67% 0
mgt-element.dist.es6.providers.src.providers 85% 69% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 84% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (12381 / 19095) 63% (391 / 622) 0

Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-people-picker enables presence badges requiring new consent without configuration to opt out.
3 participants