You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposal: For the electron provider, make the electron package a peer dependency
Description
The electron package is currently listed as a direct dependency of mgt-electron-provider, and is quite an old version. I can't use it in my project which depends on 24.8.1 due to breaking changes in the electron api (see discussion topic here). Is it possible to make electron a peer dependency so we can bring our own versions?
Rationale
Consumers of mgt-electron-provider are presumably working across a wide range of electron versions, so making it a peer dependency makes sense in my mind.
Preferred Solution
List electron as a peer dependency
Additional Context
I admit that I'm not very knowledgeable with the ins and outs of node library development. There might be a very good reason that making electron a peer dependency is simply not possible here, and my request might seem naive as a result.
The text was updated successfully, but these errors were encountered:
@gavinbarron thanks for the response, however is there any way to list it as a peer dependency so we can bring our own version? Locking developers into a single major version of electron might cause a lot of headaches, sometimes we're stuck in a single version for one reason or another.
For example, I wouldn't be able to use the current major version of electron (or any of the recent major versions), I'm stuck on 24 until they fix a couple of printing bugs that exist beyond 24.8.1 (electron/electron#39179 and electron/electron#31705)
Proposal: For the electron provider, make the electron package a peer dependency
Description
The electron package is currently listed as a direct dependency of mgt-electron-provider, and is quite an old version. I can't use it in my project which depends on 24.8.1 due to breaking changes in the electron api (see discussion topic here). Is it possible to make electron a peer dependency so we can bring our own versions?
Rationale
Consumers of mgt-electron-provider are presumably working across a wide range of electron versions, so making it a peer dependency makes sense in my mind.
Preferred Solution
List electron as a peer dependency
Additional Context
I admit that I'm not very knowledgeable with the ins and outs of node library development. There might be a very good reason that making electron a peer dependency is simply not possible here, and my request might seem naive as a result.
The text was updated successfully, but these errors were encountered: