Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the electron package a peer dependency in mgt-electron-provider #2904

Closed
lwestfall opened this issue Dec 7, 2023 · 4 comments · Fixed by #3046
Closed

Make the electron package a peer dependency in mgt-electron-provider #2904

lwestfall opened this issue Dec 7, 2023 · 4 comments · Fixed by #3046

Comments

@lwestfall
Copy link
Contributor

Proposal: For the electron provider, make the electron package a peer dependency

Description

The electron package is currently listed as a direct dependency of mgt-electron-provider, and is quite an old version. I can't use it in my project which depends on 24.8.1 due to breaking changes in the electron api (see discussion topic here). Is it possible to make electron a peer dependency so we can bring our own versions?

Rationale

Consumers of mgt-electron-provider are presumably working across a wide range of electron versions, so making it a peer dependency makes sense in my mind.

Preferred Solution

List electron as a peer dependency

Additional Context

I admit that I'm not very knowledgeable with the ins and outs of node library development. There might be a very good reason that making electron a peer dependency is simply not possible here, and my request might seem naive as a result.

@gavinbarron
Copy link
Member

I think we're going to be incrementing the dependency version to 28 via another PR shortly

@lwestfall
Copy link
Contributor Author

@gavinbarron thanks for the response, however is there any way to list it as a peer dependency so we can bring our own version? Locking developers into a single major version of electron might cause a lot of headaches, sometimes we're stuck in a single version for one reason or another.

For example, I wouldn't be able to use the current major version of electron (or any of the recent major versions), I'm stuck on 24 until they fix a couple of printing bugs that exist beyond 24.8.1 (electron/electron#39179 and electron/electron#31705)

@sebastienlevert
Copy link
Contributor

@gavinbarron, is that work planned with the new Electron provider? I felt we discussed this but can't see it in main branch with the peer dependency.

@gavinbarron
Copy link
Member

we talked about it but never committed to doing it.

It's work that we should do but I really need a functional sample using the latest bits for this to be something we can tackle with confidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants