Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for nested values in mgt-picker key-name #2917

Merged

Conversation

andreasomayrat
Copy link
Contributor

Closes #2907

PR Type

Feature

Description of the changes

Allows the use of nested values in the mgt-picker component's key-name property, for example "fields.myCustomColumn"

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR: No docs update needed
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Stories not updated but existing stories have been tested

@andreasomayrat andreasomayrat requested a review from a team as a code owner December 14, 2023 15:54
@andreasomayrat andreasomayrat marked this pull request as draft December 14, 2023 16:27
@andreasomayrat andreasomayrat marked this pull request as ready for review December 15, 2023 15:27
@andreasomayrat
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Sherpas Group AB"

@gavinbarron gavinbarron enabled auto-merge (squash) January 2, 2024 17:13
@gavinbarron
Copy link
Member

@andreasomayrat to have this merged you will need to update your branch with the changes that have happened in main.

Thanks again for the great work on this enhancement

Copy link
Collaborator

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this addition!

@sebastienlevert
Copy link
Contributor

Quick ping on this one @andreasomayrat! If you could update with the latest version of branch this would be amazing! Thanks!

auto-merge was automatically disabled January 23, 2024 10:18

Head branch was pushed to by a user without write access

@andreasomayrat
Copy link
Contributor Author

@sebastienlevert i have now rebased against the latest main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
5 participants