Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/lazy collections beta #515

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Feature/lazy collections beta #515

merged 6 commits into from
Jan 25, 2023

Conversation

hg-ms
Copy link
Contributor

@hg-ms hg-ms commented Jan 24, 2023

Lazy collections implementation
-LazyArrayList
-LazyHashMap
-LazyHashSet

hg-ms added 2 commits January 24, 2023 09:54
@hg-ms
Lazy collections implementation
3d763e7 
Lazy collections implementation
-LazyArrayList
-LazyHashMap
-LazyHashSet
@hg-ms
Update Jenkins config to match master
e528f77
@hg-ms hg-ms requested review from zdenek-jonas and fh-ms January 24, 2023 09:51
fh-ms
fh-ms reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@fh-ms fh-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some 'format' comments, and then I realized that there are a lot of places where the indentation is odd, but maybe it is just the GitHub viewer.

base/src/main/java/one/microstream/collections/lazy/LazyCollection.java Outdated Show resolved Hide resolved
base/src/main/java/one/microstream/collections/lazy/LazyArrayList.java Outdated Show resolved Hide resolved
base/src/main/java/one/microstream/collections/lazy/LazyArrayList.java Outdated Show resolved Hide resolved
base/src/main/java/one/microstream/collections/lazy/LazyArrayList.java Show resolved Hide resolved
base/src/main/java/one/microstream/collections/lazy/LazyArrayList.java Outdated Show resolved Hide resolved
base/src/main/java/one/microstream/reference/LazyClearObserver.java Outdated Show resolved Hide resolved
base/src/main/java/one/microstream/reference/ObservedLazyReference.java Outdated Show resolved Hide resolved
persistence/binary/src/main/java/module-info.java Show resolved Hide resolved
hg-ms added 2 commits January 24, 2023 14:07
@hg-ms
fixed review findings
548d30f 
- fixed whitespaces
- renamed ObservedLazyReference to ControlledLazyReference
- renamed BinaryHandlerLazyObservable  to BinaryHandlerControlledLazy
- renamed LazyClearObserver to LazyClearController
- made lazy collections implementations final
- made LazySegmentUnloader implementations final
- made binary handler final
@hg-ms
added collections.lazy to exports
7ddec98
fh-ms
fh-ms reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@fh-ms fh-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last typo.

base/src/main/java/one/microstream/reference/ControlledLazyReference.java Outdated Show resolved Hide resolved
@hg-ms hg-ms requested a review from fh-ms January 24, 2023 13:55
@hg-ms hg-ms merged commit 75dc735 into master Jan 25, 2023
@hg-ms hg-ms deleted the feature/lazy-collections-beta branch January 25, 2023 10:32
@fh-ms fh-ms added this to the 08.00.00 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fh-ms fh-ms fh-ms approved these changes

@zdenek-jonas zdenek-jonas zdenek-jonas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
08.00.00
Development

Successfully merging this pull request may close these issues.
3 participants
@hg-ms @zdenek-jonas @fh-ms