Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDNS ExtendedRcode return uint size #341

Closed
McStork opened this issue Apr 10, 2016 · 1 comment · Fixed by #347
Closed

EDNS ExtendedRcode return uint size #341

McStork opened this issue Apr 10, 2016 · 1 comment · Fixed by #347

Comments

@McStork
Copy link
Contributor

McStork commented Apr 10, 2016

Hi,
After the recent update of ExtendedRcode, the return type which was uint8 should be upgraded to at least uint16, as it can now return an integer of a size up to 12bits.
@McStork McStork mentioned this issue Apr 10, 2016
Merged
@miekg
Copy link
Owner

miekg commented Apr 10, 2016

yep, you're right and uint8 was never good. Pondering just int or uint16 as the fixed return code...

@McStork McStork mentioned this issue Apr 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set ExtendedRcode return type to int instead of uint8 McStork/dns
2 participants
@miekg @McStork