-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download-href doesn't work in paper-dialog #511
Comments
Maybe this is swallowing the event: https://github.com/miguelcobain/ember-paper/blob/master/addon/components/paper-dialog-inner.js#L35-L40 |
Anyway to avoid this? |
I honestly don't know why that event suppression is needed. Git blame points to @DanChadwick. Do you have any idea of why that is needed? |
@miguelcobain No memory of this as I've been on another project for a while, but isn't that needed so that the click outside the dialog only closes the dialog and isn't processed as a click. For example, you open a dialog and then click. Suppose the click happens to be on "delete all", but its dimmed by the backdrop. Or maybe I'm completely wrong. |
I see. We're just stopping the propagation, not preventing the default behavior. 🤔 |
As long as no fix exists, any idea what i could use instead of this download link? |
I know what's wrong and I know how to fix. For now, not using |
I need it tomorrow, so would be really nice to get it soon |
@BennyAlex it is fixed on master |
thank you. When will you release a new Version? Long time ago since the last one... |
v1.0.0-alpha.4 was released |
Can you tell me please, how I can use your commit as an dependency in npm? |
@BennyAlex in your But, like I said, I released alpha 4. |
Thanks again. I already tried |
@miguelcobain I have a select and now with alpha-4 I can't choose any items |
@BennyAlex that is expected. paper-menu, paper-select and paper-autocomplete aren't finished yet, as it is noted with the little warning sign on the docs. You have two options:
I strongly advise to go with the first because:
Also, you should join us at #e-paper on slack (link in the README). There are many kind people there willing to help. :) |
@miguelcobain I will have a look. I know that they are wip, but on alpha-3 it worked, and alpha-4 it is really broken |
When install
|
@BennyAlex I'm sorry, you need to run the blueprint. $ npm install --save-dev miguelcobain/ember-paper#paper-menu
$ ember g ember-paper Ignore the jshint errors for now, please. |
I just use power-select now, works fine. So I can stay on alpha-4, which is better because we are workin in a team and alpha-4 is a better dependency |
* commit '2cb9be5574a486175e48bc1a8da4186611f3ddbe': 1.0.0-alpha.4 update CHANGELOG allow inner dialog clicks to bubble. closes adopted-ember-addons#511 add ember resolution update ember-cli and fastboot call super remove Ember. property access update ember-cli to 2.8.0 make it glimmer 2 compatible WIP - remove other super calls Add super calls inside paper-input lifecycle hooks. update ember-css-transitions referencing the correct API (adopted-ember-addons#493) Match paper-sidenav demo width to AM@1.0.6 (adopted-ember-addons#482) Fix ripple artifact in Chrome 51 (adopted-ember-addons#475) update ember-css-transitions update CHANGELOG for adopted-ember-addons#466 update CHANGELOG for alpha.3 Added autoprefixer support for Safari >= 6 to use -webkit-flex (adopted-ember-addons#466)
If I have a link to download a file from the backend, inside an dialog e.g.
It dosn't trigger the download. When it's outside the dialog, it works fine.
The text was updated successfully, but these errors were encountered: