Blacklist whitelist components #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@betocantu93 an interesting addition would be to not include <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">if paper icon is blacklisted/not white listed. |
|
@miguelcobain yep, that's a good idea! |
miguelcobain
force-pushed
the
blacklist-whitelist-components
branch
from
f71b537 to
639fa7b
Compare
miguelcobain
pushed a commit
that referenced
this pull request
Nov 30, 2018
This is a follow up of the #1021 PR, this will only import the css of the whitelist-blacklist, as a reminder, you can only use one at the same time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The past PR was corrupted, this is a clean PR.
whitelist/blacklist components using ember-bootstrap approach.
For whitelist, all the component dependencies will also be included.