Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checkbox accessible #1031

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Make checkbox accessible #1031

merged 3 commits into from
Nov 28, 2018

Conversation

mikoscz
Copy link
Contributor

@mikoscz mikoscz commented Nov 28, 2018 •
edited by miguelcobain
Loading

I've added support for

  • aria-checked
  • aria-labelledby
  • aria-label
    and the role="checkbox"

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/checkbox_role

@miguelcobain Should I also add type="checkbox"? I see that the angular's version has it but I am not sure.

@miguelcobain
Copy link
Collaborator

According to MDN, type is only used on <button>, <input>, <command>, <embed>, <object>, <script>, <source>, <style>, <menu> elements.

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes

The PR LGTM! Thanks.

@mikoscz
Copy link
Contributor Author

mikoscz commented Nov 28, 2018

Thanks!

@miguelcobain miguelcobain merged commit 464bde6 into adopted-ember-addons:master Nov 28, 2018
@mikoscz mikoscz deleted the make-checkbox-accessible branch December 3, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikoscz @miguelcobain