Fix paper-autocomplete value being overriden when changed #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to add a new test for this scenario but wasn't able to get it to reproduce in a test. I did verify in my own app that it's no longer affected after this change, and the existing tests passed. Thanks! 👍 |
|
Anything holding this back from being merged? |
|
@xtagon sorry for taking so long to merge this. Thank you! |
backspace
added a commit
to backspace/ember-paper
that referenced
this pull request
Jul 21, 2019
This reverts adopted-ember-addons#1076, though then adopted-ember-addons#1043 is surely a problem again.
backspace
added a commit
to backspace/ember-paper
that referenced
this pull request
Jul 21, 2019
This shows the bug being described in adopted-ember-addons#1092. Reverting adopted-ember-addons#1076 does fix it, but then presumably adopted-ember-addons#1043 would return 😞
This was referenced Jul 21, 2019
|
@xtagon can you please retest if this bug persists on beta.26? Basically this fix introduced a new bug. We were barking at the wrong door. The bug was somewhere else. |
|
Good catch, I will have a chance to test it in the next few days. |
|
@miguelcobain beta.26 looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043