Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show validation errors if user has interacted with the element. … #151

Merged
merged 3 commits into from
Aug 19, 2015
Merged

Only show validation errors if user has interacted with the element. … #151

merged 3 commits into from
Aug 19, 2015

Conversation

mike1o1
Copy link
Contributor

@mike1o1 mike1o1 commented Aug 17, 2015

Fixes #150

@@ -14,7 +14,7 @@ export default BaseFocusable.extend(ColorMixin, FlexMixin, {
inputElementId: Ember.computed('elementId', function() {
return 'input-' + this.get('elementId');
}),
isInvalid: Ember.computed('value', function() {
isInvalid: Ember.computed('isInvalid', 'value', function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does isInvalid depend on isInvalid?

@peec
Copy link
Contributor

peec commented Aug 17, 2015

Nice one! 👍

miguelcobain added a commit that referenced this pull request Aug 19, 2015
Only show validation errors if user has interacted with the element. …
@miguelcobain miguelcobain merged commit b4d8e2d into adopted-ember-addons:master Aug 19, 2015
@mike1o1 mike1o1 deleted the display-errors-on-blur branch October 16, 2015 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants