Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject wormhole outlet through addon hook #219

Merged
merged 2 commits into from
Nov 13, 2015
Merged

Inject wormhole outlet through addon hook #219

merged 2 commits into from
Nov 13, 2015

Conversation

alexlafroscia
Copy link
Member

Instead of needing to include the Wormhole outlet in your application manually, the addon will now add the div automatically.

Note: I'm not sure if this will be backward compatible with having it also defined in the template, for people that already are using it the previous way.

Closes #214

Instead of needing to include the Wormhole outlet in your application manually, the addon will now add the `div` automatically.
@miguelcobain
Copy link
Collaborator

@alexlafroscia Looks great!

Could you please add a changelog entry for the next patch version?

@alexlafroscia
Copy link
Member Author

@miguelcobain done 👍

miguelcobain added a commit that referenced this pull request Nov 13, 2015
@miguelcobain miguelcobain merged commit 37ccdba into adopted-ember-addons:master Nov 13, 2015
@alexlafroscia alexlafroscia deleted the inject-wormhole-placeholder branch November 13, 2015 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants