Improvements to paper-icon
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an error when trying to compute iconClass when no icon is passed to the component.
Ideally we wouldn't need a separate `positionalIcon` property and could just use `icon`, but this is not permitted (see emberjs/ember.js#12350)
SaladFork
force-pushed
the
feature/paper-icon-positional-params
branch
from
ec2af85 to
d3ed897
Compare
|
Excellent. Thanks. |
miguelcobain
added a commit
that referenced
this pull request
Jan 28, 2016
…params Improvements to `paper-icon`
|
Can you please add an entry in CHANGELOG.md? |
|
Yup, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paper-icon(previously untested){{paper-icon "check"}}in addition to{{paper-icon icon="check"}}