Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix included _super class #520

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Conversation

machty
Copy link
Contributor

@machty machty commented Oct 12, 2016

This fixes issues with people seeing regeneratorRuntime is not defined when ember-concurrency / ember-maybe-import-regenerator are deeply nested dependent addons.

This new ember app demonstrates the bug and is fixed with this change to ember-paper.

Prior art: ember-cli/ember-cli#3718 (comment)

This fixes issues with people seeing `regeneratorRuntime` is not defined when ember-concurrency / ember-maybe-import-regenerator are deeply nested dependent addons.

[This new ember app](https://github.com/v3ss0n/ember-paper-menu-error-concurrency) demonstrates the bug and is fixed with this change to ember-paper.

Prior art: ember-cli/ember-cli#3718 (comment)
@v3ss0n
Copy link

v3ss0n commented Oct 13, 2016

Thanks a lot! @machty that was quick!

@miguelcobain
Copy link
Collaborator

Thanks, @machty!

@miguelcobain miguelcobain merged commit 6f9589a into adopted-ember-addons:master Oct 13, 2016
@v3ss0n
Copy link

v3ss0n commented Oct 13, 2016

@miguelcobain i think it should b merged to #395 branch since the ember-power-select cause the bug there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants