use computed.bool instead of directly messages length

[panthony]

because computed.or does not coalesce to bool, we otherwise end up with the number of errors instead of true in isInvalid and isInvalidAndTouched

Signed-off-by: Anthony Pessy anthony.pessy@gmail.com

[miguelcobain]

Can you convert these to integration tests, please?

[miguelcobain]

Can we promote

hasErrorMessages: computed.bool('validationErrorMessages.length'),

to the Mixin

and then paper-input would just override isInvalid to account for native invalids?

[panthony]

@miguelcobain In ValidationMixin we would have:

  hasErrorMessages: computed.bool('validationErrorMessages.length'),

  isInvalid: computed.bool('validationErrorMessages.length'),

And in paper-input:

  isInvalid: computed.or('hasErrorMessages', 'isNativeInvalid'),

Is that correct?

[miguelcobain]

I was thinking, for consistency

// validation-mixin.js
hasErrorMessages: computed.bool('validationErrorMessages.length'),
isInvalid: computed.reads('hasErrorMessages'),

and

// override validation mixin `isInvalid` to account for the native input validity
isInvalid: computed.or('hasErrorMessages', 'isNativeInvalid'),

Please include the comment to make it clearer.

[miguelcobain]

Thanks!