resolve swipe name conflict #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when swipe is a valid event name, i.e., when using ember-gestures
|
Thanks. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a function that is named after an event on a tagless component is an error in glimmer. The paper-toast component has a method named
swipe. Normally this isn't a problem becauseswipeis an official event registered with the event dispatcher. But when usingember-gesturesthere is aswipeevent, making it impossible to usepaper-toast. However, here, the tagless component has a methodswipeout of coincidence. By renaming this method we solve the problem. This fixes issue #853.