3.4 Closure actions deprecation #973
Conversation
…nd make it easier to mantain
|
Any progress on merging this? |
|
@betocantu93 Thank you very much for this. The addon has a functional utility, just like you made here, and also has a mixin. I'd prefer the functional utility because it is better aligned with ES6 classes which don't support mixins. I'm planning to migrate ember-paper soon. Using this addon promotes using shared solutions and it is already tested against many ember versions. |
|
@miguelcobain Interesting, nice addon. Excellent news about ember-paper migration, let us know if you need help with that - also I was planning an attempt to get ember-paper run without any jquery - and sure, I can do the addon thing, I'll push to this branch I guess. |
addon/components/paper-chips.js
Outdated
| @@ -170,7 +171,7 @@ export default Component.extend({ | |||
|
|
|||
| noUnselected(old, event) { | |||
| if (['Backspace', 'Delete', 'Del', 'ArrowLeft', 'Left', 'ArrowRight', 'Right'].includes(event.key)) { | |||
| this.sendAction('keyDown', event); | |||
| invokeAction(this, 'keyDown', item); | |||
There was a problem hiding this comment.
Exactly. This is the error on travis.
Linting tests are useful after all, huh.
|
Thanks a lot for this! |
Deprecations Added in 3.4
Use closure actions instead of
sendActionhttps://emberjs.com/deprecations/v3.x#toc_ember-component-send-action