Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple file extensions when using getMultiFilePath() #68

Closed
Ghxst opened this issue Apr 9, 2019 · 6 comments
Closed

Multiple file extensions when using getMultiFilePath() #68

Ghxst opened this issue Apr 9, 2019 · 6 comments
Labels
suggestion New feature or request

Comments

@Ghxst
Copy link

Ghxst commented Apr 9, 2019

Hey, I've seen 2 issues before me, #42 and #32 .
The questions are both closed but I can't seem to find a mention of this feature being added in the changelog.

For clarification, I'm looking to pick multiple files of a pre-defined extension (for example .jpg and .mp4).

Maybe I have missed it somewhere, if so, apologies.

@miguelpruivo
Copy link
Owner

Hi. If you want to pick images or videos you can use FileType.IMAGE or FileType.VIDEO respectively. However, picking both images (jpg) and video (mp4) at the same time isn’t currently supported, for that I suggest you to use FileType.ALL that lets you pick anything and then you can quickly check if any of the picked files are not jpg/mp4.

Thank you for the suggestion.

@Ghxst
Copy link
Author

Ghxst commented Apr 9, 2019

Thank you for the clarification, I will follow your advice and use FileType.ALL for the time being, I hope to see multiple file extensions implemented in the future. If I may, I would like to suggest the solution discussed in #32 or a delimiter such as 'jpg|mp4' so it doesn't break existing code.

Thank you for the great work.

@miguelpruivo
Copy link
Owner

I will take this in consideration if possible for both platforms.

As a note, I always try to avoid making a feature only available to a specific platform to make the experience as seamlessly as possible. Android, in general, is more flexible and supports more options that iOS, however, it is also more tricky to handle for the available scenarios.

So if sometimes I don't add a requested feature, may be because it isn't supported by one platform even if it's supported by the other.

@miguelpruivo miguelpruivo added the suggestion New feature or request label Apr 9, 2019
@miguelpruivo miguelpruivo mentioned this issue Jun 20, 2019
6 tasks
@miguelpruivo
Copy link
Owner

Moved to #99.

@devjeff
Copy link

devjeff commented Sep 8, 2019

It would be great to define multiple file extensions in combination with the "FileType.CUSTOM" parameter when selecting a single file. Of course you can check the selected file type afterwards, but it would be a better user experience if the user wouldn't even be able to select an unsupported file type in the first place.

@miguelpruivo
Copy link
Owner

@whigger85 thank you for the input, it surely will be added in a future update if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants