Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support some icons #174

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

bjohansebas
Copy link
Contributor

@jacobdalamb
Copy link
Contributor

I'm not familiar with husky but creating these files by themselves in vscode have them set as plain text. I don't think file names should be set to specific file extensions.

@bjohansebas
Copy link
Contributor Author

I'm not familiar with husky but creating these files by themselves in vscode have them set as plain text. I don't think file names should be set to specific file extensions.

Husky follows a script format like this:

imagen

In my opinion, it can have the shell icon or a custom one.

@miguelsolorio miguelsolorio self-requested a review March 11, 2024 19:43
@miguelsolorio miguelsolorio added this to the 0.0.17 milestone Mar 11, 2024
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR ❤️

and there are other file icon themes that do something similar, I personally don't mind it so will merge it in (anyone else can configure this via user settings)

@miguelsolorio miguelsolorio merged commit 0db3dc3 into miguelsolorio:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants