Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow icon theme to run on the web and remote #46

Open
miguelsolorio opened this issue Aug 30, 2022 · 3 comments
Open

Allow icon theme to run on the web and remote #46

miguelsolorio opened this issue Aug 30, 2022 · 3 comments
Assignees
Labels
feature request Request for new functionality

Comments

@miguelsolorio
Copy link
Owner

This icon theme uses javascript to dynamically create the non-chevron tree version via the settings symbols.hidesExplorerArrows. Due to this, it means that the theme can't run on the web (vscode.dev) and additionally when used in remote environments (ssh or codespaces) you have to manually install the theme on each environment as opposed to it running on your main machine.

CleanShot 2022-08-30 at 07 51 32@2x

One possible solution is to remove the javascript and create a pre-publish build task that will generate the copy so there wouldn't be a need for the dynamic javascript. cc @barelyhuman

@miguelsolorio miguelsolorio added the feature request Request for new functionality label Aug 30, 2022
@miguelsolorio miguelsolorio self-assigned this Aug 30, 2022
@barelyhuman
Copy link
Contributor

can be done , any preferred deadlines?

@miguelsolorio
Copy link
Owner Author

Oh none at all, this is a passion project 😄 just wanted to capture some ideas around it. The one challenge with using a build task is that PRs will likely need a github action to generate the file.

@barelyhuman
Copy link
Contributor

i was going to involve that in the task, will do that soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants