Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update nextjs icon #55

Merged
merged 3 commits into from
Nov 13, 2022
Merged

feat: update nextjs icon #55

merged 3 commits into from
Nov 13, 2022

Conversation

chrisgrabinski
Copy link
Contributor

The Next.js logo has recently been redesigned and unveiled shortly before Next.js Conf 2022.

This updated icon is based on the apple-touch-icon.png from https://nextjs.org

Original Vector recreation
apple-touch-icon from nextjs.org Vector recreation of apple-touch-icon from nextjs.org

The new icon is using a scaled version of the vector recreation:

Before After
Original icon for Next.js Updated icon for Next.js

miguelsolorio
miguelsolorio requested changes Nov 7, 2022
View reviewed changes
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We try to not use the plain white color as this won't look great on light themes. Mind using the same color as the previous icon?

@chrisgrabinski
Copy link
Contributor Author

chrisgrabinski commented Nov 8, 2022 •
edited
Loading

Thanks for the PR! We try to not use the plain white color as this won't look great on light themes. Mind using the same color as the previous icon?

Absolutely! I have changed #ffffff to #64748B as in the previous icon and I also made some minor tweaks to the gradient for better contrast when used in this small size and color.

Before Adjusted color Adjusted gradient
Updated icon for Next.js Updated icon for Next.js with previous color Updated icon for Next.js with previous color and adjusted gradient

miguelsolorio
miguelsolorio approved these changes Nov 13, 2022
View reviewed changes
Copy link
Owner

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

CleanShot 2022-11-13 at 11 13 53@2x

@miguelsolorio miguelsolorio merged commit 002f87a into miguelsolorio:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsolorio miguelsolorio miguelsolorio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgrabinski @miguelsolorio