Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package ABI stable? #12

Closed
clarkttfu opened this issue Mar 5, 2019 · 4 comments
Closed

Is this package ABI stable? #12

clarkttfu opened this issue Mar 5, 2019 · 4 comments

Comments

@clarkttfu
Copy link

Hi, I found this package actually use libuv directly, and the N-API guide said I should stick with napi.h.
Excellent works anyway!!

@mika-fischer
Copy link
Owner

At the time I wrote this, there was just no other way. And there were some discussions about what parts of libuv (if any) should be considered stable. I don't know what came of these discussions.

However, nowadays this is supported directly in napi: https://nodejs.org/dist/latest-v10.x/docs/api/n-api.html#n_api_asynchronous_thread_safe_function_calls

@clarkttfu
Copy link
Author

Actually I found those new APIs at first, but due to product limitation we have to stick with 8.x..
And I thought this package could be life saving. I will do some tests and let you know the result.
Thank you anyway!

@mika-fischer
Copy link
Owner

FWIW, here's the discussion I mentioned: nodejs/node#13512 (comment)

@clarkttfu
Copy link
Author

clarkttfu commented Mar 7, 2019

According to the descriptions, libuv is actually quite stable nowadays. IMHO, the N-API is to isolate the v8 changes. I have removed the dependency to this package from my code -- uv_async_init and uv_async_send are all I needed. And the build run without issue on 6.14.2 / 6.17.0 / 8.15.1 and 10.15.3.

So I guess this package should be ABI stable too, but I don't have time for those works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants