Brackets crash when search on project

[cyrakuse]

When i configure the extension to search in the whole project ("scope": "project"), Brackets crash after many second of freeze.
I use Brackets 37

[mikaeljorhult]

I am unable to reproduce this error. Could you try the newly released 0.5.2?

[cyrakuse]

I've the same problem with the last update.
It's like Brackets freeze during search and Windows detect that spend too much time and display "Brackets stop working" error.
i'm on win 8 x64

[mikaeljorhult]

Is it a large project? Have you tried it with a smaller one?

[cyrakuse]

I is a relation with a Brackets issue (adobe/brackets#6091)
when we "search on files", it bug when we have binary files like PDF, PSD, MP4, AVI....
So i exclude these binary files in the .todo config file and it work properly.
Maybe these files could be excluded by default.

[mikaeljorhult]

Thank you for looking into it. I'll have a go at it this week to see how to best avoid the binaries.

[cyrakuse]

i have an idea :
in the new preference system, you can add a list of autorized types of files (because a list of excluded files is impossible to make)

Another idea :
the options of the .todo file could be injected in the prefernce system. Then all users can customize their option for all projects.
If we have specifics option for one project, we also can add a .todo file in it.

Then this should limit the problems

[mikaeljorhult]

I'm working on a settings dialog for the extension so that you can set your own defaults for all projects. My plan is that you will also be able to override these using the .todo to be able to have project specific settings.

[cyrakuse]

exactly my second idea. perfect 👍

just need to resolve the binary files issue now ;)

[zaggino]

You should be able to easily check for binary files like this in your FileManager.js I think.
https://github.com/zaggino/brackets-git/blob/master/src/Panel.js#L507-L508

[mikaeljorhult]

Thank you @zaggino. That seems to do the trick.

@cyrakuse Could you please try the current version in the repository to see if it solves your problems.

[mikaeljorhult]

A fix for this is included in version 0.5.3 (db8b1f6).