Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https not http for the dripper #35

Closed
allotmentandy opened this issue Sep 2, 2016 · 6 comments
Closed

https not http for the dripper #35

allotmentandy opened this issue Sep 2, 2016 · 6 comments

Comments

@allotmentandy
Copy link

allotmentandy commented Sep 2, 2016

hi,

i want to know how to force the caffeine dripper to use a https url instead of a http? is there a way to add a setting FORCE_HTTPS?

kind regards

Andy

@mikebronner
Copy link
Owner

The drip url is generated using the url() helper, which gets the base url from Laravel. This means it will use the same schema as your Laravel app is configured to use.

Do you have a use-case where you wouldn't want it to behave this way? (If your Laravel app is on HTTPS, but drip is not pointing to HTTPS, my guess is there is probably a configuration issue in your Laravel app.) Please let me know. :)

Thanks!
~Mike

@allotmentandy
Copy link
Author

hi, thanks for the reply.

i have the laravel app running behind a load balancer. so the internal laravel system is http but the client facing part is https.

i have changed the line in the middleware to just call
$dripUrl = '/genealabs/laravel-caffeine/drip';

as the url part is broken, when i use the load balancer.

but it is going to break when there is an update!

Andy

@mikebronner
Copy link
Owner

Excellent use case, I forgot to consider that! Thanks for bringing this up, I will add that as a configuration option.

@allotmentandy
Copy link
Author

could you just have a full url in the config file?

@mikebronner
Copy link
Owner

Will definitely consider it. It will probably be two config values, one for the base URL (schema and domain) and another for the actual route on the app.

@allotmentandy
Copy link
Author

yes, perhaps you can have url() as the default for the first one, so i can overright it.

thanks for a great package and great service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants