Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I plan to make XML docs for HidLibrary, how would you prefer I submit PRs? #107

Open
akmadian opened this issue Mar 26, 2019 · 2 comments
Open

Comments

@akmadian
Copy link

I'd be happy to work on some XML docs for HidLibrary, in fact I've already started!

When I submit PRs, would you prefer that I submit a PR for each newly documented class, or just get it done all at once and PR then? I ask because my knowledge of HID communication is ok, but not great, and I want to be sure that all of the docs are factually correct in terms of protocol and implementation. I figure that submitting incremental PRs gives the maintainers a chance to ok all new docs as they come in, instead of getting a massive dump all at once.

Thanks, I love the project, and it's been a big help to me in my work!

@akmadian
Copy link
Author

akmadian commented Apr 9, 2019

Pinging @mikeobrien cause it's been a couple weeks

@mikeobrien
Copy link
Owner

Hey thanks for the offer and sorry for the late reply! Life has been crazy this year... Yeah, if you want to submit a PR I'll get it merged. Thx again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants