-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name of users to PRs placeholders #1360
Comments
It seems that this could be added in here as another placeholder:
|
Please test it out in v5.0.0-rc03 |
@mikepenz I've tested it, however for some reason it's always empty 😢 - I'm not sure why, as we have our full names in our github profiles - any advice? Sorry for a long time without response |
@dnaploszek you work with PRs for the changelog? or commit based? |
Squashed and merged commits from tag to tag |
Then this is the problem I believe. commits don't have GitHub users associated if I am not mistaken. It should work for PRs though |
That's odd, afaik we were using something different earlier that could extract the user name and it was working there, however I just jumped into this to resolve it at a later date so I cannot provide more details out of the box - maybe Ilya could - I'll sync with him on this soon |
Well I've investigated it myself + talked with the team, for some reason it's not filled - sorry to bother, unfortunately this didn't solve our issue, we'll need to use github logins for references |
Thanks for following up. I wonder if there's something else we can do. if you had a reproducible public open source repo or something we can test with faster that would help |
Now we have an "Author" placeholder, that's a GitHub username, but I'd like to get another placeholder with the author name(full name).
The text was updated successfully, but these errors were encountered: