Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name of users to PRs placeholders #1360

Closed
ilya-hontarau opened this issue Aug 6, 2024 · 9 comments · Fixed by #1361
Closed

Add name of users to PRs placeholders #1360

ilya-hontarau opened this issue Aug 6, 2024 · 9 comments · Fixed by #1361

Comments

@ilya-hontarau
Copy link

Now we have an "Author" placeholder, that's a GitHub username, but I'd like to get another placeholder with the author name(full name).

@dnaploszek
Copy link

It seems that this could be added in here as another placeholder:

author: commit.author?.login || commit.commit.author?.name || '',

@mikepenz
Copy link
Owner

mikepenz commented Aug 7, 2024

Please test it out in v5.0.0-rc03

@dnaploszek
Copy link

@mikepenz I've tested it, however for some reason it's always empty 😢 - I'm not sure why, as we have our full names in our github profiles - any advice? Sorry for a long time without response

@mikepenz
Copy link
Owner

@dnaploszek you work with PRs for the changelog? or commit based?

@dnaploszek
Copy link

Squashed and merged commits from tag to tag

@mikepenz
Copy link
Owner

Then this is the problem I believe. commits don't have GitHub users associated if I am not mistaken. It should work for PRs though

@dnaploszek
Copy link

That's odd, afaik we were using something different earlier that could extract the user name and it was working there, however I just jumped into this to resolve it at a later date so I cannot provide more details out of the box - maybe Ilya could - I'll sync with him on this soon

@dnaploszek
Copy link

Well I've investigated it myself + talked with the team, for some reason it's not filled - sorry to bother, unfortunately this didn't solve our issue, we'll need to use github logins for references

@mikepenz
Copy link
Owner

mikepenz commented Oct 7, 2024

Thanks for following up. I wonder if there's something else we can do. if you had a reproducible public open source repo or something we can test with faster that would help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants