Pass string as method argument

[dereuromark]

Is there a reason the string has to be put into the constructor, and the actual config happens at runtime?
It makes it difficult for DI and libraries/config to adjust the object ones in constructing and then using it.

If you look into e.g.
https://commonmark.thephpleague.com/1.5/extensions/github-flavored-markdown/
or https://github.com/kzykhys/Ciconia/blob/master/src/Ciconia/Ciconia.php#L42

Then you usually make the builder itself stateless and instead wrap statefulness internally.

$env = .. // Can contain all the filters and stuff
$options =  [
    'xhtmlOutput' => true,
    'strictMode' => false,
    'escapeHtml' => true
];

// We can pass defaults here if we want
$instance = new Decoda($env, $options);

// We can also set options here per convertion
$html = $instance->convert($bbcodeText, $options);
$html2 = $instance->convert($bbcodeText2, $otherOptions);

What do you think?

There will also be no need for reset() then as it keeps the wrapper stateless and reuses the objects here.

[dereuromark]

It also made the implementation here a bit more difficult: https://github.com/dereuromark/cakephp-markup/pull/5/files#diff-bceef8e25512a4d6ae70ac8dad7cf2a7R73
And effectively without being able to cache the stateless filters/hooks

[milesj]

No strong reason that I remember. If I were to rewrite this now, I would most likely move the string to parse(), so that the same instance can be reused.

[alquerci]

@dereuromark On the Symfony bundle the pattern used is the factory one.

See https://github.com/helios-ag/FMBbCodeBundle/blob/350d7c0/Decoda/DecodaManager.php#L96
Usage https://github.com/helios-ag/FMBbCodeBundle/blob/350d7c0a01ac3ab057df836966fbd6c155721af7/Templating/BbcodeExtension.php#L60

Maybe this can help you.