Py3 fixes to lib/color_compliment.py #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes three bugs identified when using
--colorized-hostname
with Python3. I don't have confirmation yet, but this likely addresses issue #216. I usedtry/except
blocks and version checks to be conservative and ensure this doesn't break for anyone on a very old Python 2 version, but this was probably excessive and isn't something I would have done on my own project. I'd be happy to remove them if there are concerns about the overhead.With these changes made, I've had no problems on Python 2.6.6, 2.7.10, and 3.5.1.
Issue 1 fixed in ceholden/powerline-shell@1f1acb81cba48e35820c4a88b4c39ab5ff40db42:
Issue 2 fixed in ceholden/powerline-shell@c07c4be6b4e410a56bc95284bb553f5b1baaa7f7:
Issue 3, previously mentioned but not merged in #82, fixed in ceholden/powerline-shell@6bef8fab1dc86739f6073d8dfbacc1fb20dc1edc: