Moved all repo stats code from git.py to the base #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all of the new code to provide more interesting stats was added to git.py, it was not very re-usable. A few pull requests could use it though. In particular, #105 adds more info to the svn segment and #210 does the same for mercurial. I would rather not create inconsistencies among these segments or have them duplicate code. Moving it into the base file creates a place where each segment can access it and have a consistent behavior.
amtrivedi91
added a commit
to amtrivedi91/powerline-shell
that referenced
this pull request
Aug 31, 2016
Moved all repo stats code from git.py to the base
amtrivedi91
added a commit
to amtrivedi91/powerline-shell
that referenced
this pull request
Aug 31, 2016
amtrivedi91
added a commit
to amtrivedi91/powerline-shell
that referenced
this pull request
Aug 31, 2016
Moved all repo stats code from git.py to the base
amtrivedi91
added a commit
to amtrivedi91/powerline-shell
that referenced
this pull request
Aug 31, 2016
LeonardoGentile
added a commit
to LeonardoGentile/powerline-shell
that referenced
this pull request
Sep 6, 2016
* 'master' of github.com:banga/powerline-shell: (38 commits) changelog fix unicode issue for py3 move changelog to own file, add changelog for b-ryan#221 no need for a ternary Moved all repo stats code from git.py to the base readme note about b-ryan#212 convert uptime comments into test cases add circle.yml that installs dev_requirements.txt add tests for the git segment have the install script add each segment so the files can be imported for testing readme note Fix sys.version_info for Python<=2.6 Fix unicode digest error on Py3 Fix py3 ImportError by using relative import Try hashlib over md5 (md5 is deprecated) change the install command's hashbang to just python Docs: rm indent level in codeblock release note only include the user's theme if it is not the default release note ... # Conflicts: # powerline_shell_base.py # segments/git.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all of the new code to provide more interesting stats was added to
git.py, it was not very re-usable. A few pull requests could use it
though. In particular, #105 adds more info to the svn segment and #210
does the same for mercurial. I would rather not create inconsistencies
among these segments or have them duplicate code. Moving it into the
base file creates a place where each segment can access it and have a
consistent behavior.