Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if CPU instruction sets are illegal #2054

Closed
BossZou opened this issue Apr 23, 2020 · 1 comment · Fixed by #2055
Closed

Check if CPU instruction sets are illegal #2054

BossZou opened this issue Apr 23, 2020 · 1 comment · Fixed by #2055
Assignees
@BossZou
Labels
kind/feature Issues related to feature request from users priority/urgent Must be staffed and worked on either currently, or very soon, ideally in time for the next release. severity/minor Minor, Function does work, but not perfectly.

Comments

@BossZou
Copy link
Contributor

BossZou commented Apr 23, 2020

Is your feature request related to a problem? Please describe.
Currently milvus need user's CPU supports at least one of the following instruction sets: sse4_2, avx2, avx512. We will check if CPU is available.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.
@BossZou BossZou added kind/feature Issues related to feature request from users priority/urgent Must be staffed and worked on either currently, or very soon, ideally in time for the next release. severity/minor Minor, Function does work, but not perfectly. automerge labels Apr 23, 2020
@BossZou BossZou self-assigned this Apr 23, 2020
@BossZou BossZou changed the title Check if CPU instruction sets is illegal Check if CPU instruction sets are illegal Apr 23, 2020
@BossZou BossZou mentioned this issue Apr 23, 2020
Merged
@BossZou
Copy link
Contributor Author

BossZou commented Apr 24, 2020

Need to invalidate milvus behavior on several CPUs which are different from instruction sets:

  1. Support avx512
  2. Not support avx512 but avx2
  3. Not support avx512, avx2 but sse4_2
  4. Support none of avx512, avx2, sse4_2

@BossZou BossZou mentioned this issue Apr 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BossZou BossZou

Labels
kind/feature Issues related to feature request from users priority/urgent Must be staffed and worked on either currently, or very soon, ideally in time for the next release. severity/minor Minor, Function does work, but not perfectly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cpu instruction sets check
1 participant
@BossZou