Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always store kernel excess in db #229

Closed
lehnberg opened this issue Oct 1, 2019 · 0 comments
Closed

Always store kernel excess in db #229

lehnberg opened this issue Oct 1, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lehnberg
Copy link
Collaborator

lehnberg commented Oct 1, 2019

As proposed by @jaspervdm during dev meeting. Full discussion on gitter: https://gitter.im/grin_community/dev?at=5d9373c9eb1eff63d65a27bf


Description

  • Currently, the kernel excess of a tx is stored only if the user is the sender and there is no change output.
  • This should change so that the kernel excess is always stored for every transaction inserted into the db, regardless if the user is a sender or receiver.

Motivation

  • It can't be calculated after the fact, so if the user needs it sometime later for whatever reason, they are out of luck;
  • Users can use it to quickly find a particular tx on block explorers;
  • Exchanges/pools/payment providers can use it to check on-chain status without relying on the grin-wallet. They can also communicate it to their users as something that is analogous to an on-chain txid

Note

  • Not every tx will always have a excess associated to it (for example it won't be recoverable when restoring from seed).
  • While introducing this change, it MUST be ensured that the code that's selectively doing the kernel lookup is not triggered. It's currently triggered based on the presence of a stored kernel excess.
@lehnberg lehnberg added the enhancement New feature or request label Oct 1, 2019
@lehnberg lehnberg added this to the 2.1.0 milestone Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants