Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Height in ping/pong is unnecessary #1779

Closed
DavidBurkett opened this issue Oct 17, 2018 · 2 comments
Closed

Height in ping/pong is unnecessary #1779

DavidBurkett opened this issue Oct 17, 2018 · 2 comments
Labels
needs more info question

Comments

@DavidBurkett
Copy link
Contributor

What's the point of having height in the ping/pong messages when we already have total_difficulty?

I found this PR: #407 which suggests it was only necessary for testing purposes, but apparently at some point it ended up getting merged into master.
@antiochp
Copy link
Member

antiochp commented Oct 17, 2018 •
edited
Loading

Nice catch.

I suspect everyone has got used to seeing peer heights in the TUI at this point though...

@DavidBurkett
Copy link
Contributor Author

It seems inconsistent to not also have it in the hand/shake messages, though. If we're going to keep it in ping/pong, and therefore allow consumers to make decisions based on it, it seems like we should also include it in the handshake so they aren't required to wait for a ping/pong before having the info.

@DavidBurkett DavidBurkett mentioned this issue Apr 30, 2019
Closed
@antiochp antiochp mentioned this issue Dec 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs more info question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lehnberg @DavidBurkett @antiochp