Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node receives a orphan block (via gossip) with more work than current chain head #411

Closed
antiochp opened this issue Nov 30, 2017 · 2 comments

Comments

@antiochp
Copy link
Member

In this situation it appears we just saw a block on the network that is part of a chain further ahead than we are.
Can we ask for the "previous" block in this case (and do this recursively as we receive still-orphaned blocks).
Is there any reason not to want to start trying to de-orphan-ize it?
Regardless of what the sync will do when it kicks off it seems likely we will want to retrieve these intermediate blocks?

One thing I can think of is the case where we have multiple forks that are all ahead of us - ideally we're just focused on catching up with the one single "true" chain.
Everything else is just wasted effort.

@ignopeverell
Copy link
Contributor

Wouldn't we always have a higher difficulty from that peer in the first place though? And so be trying to sync already?

@antiochp
Copy link
Member Author

antiochp commented Dec 1, 2017

I think so yeah. Closing this.
I believe what I was seeing when I started thinking about this is described in #412 when it appeared we were seeing a peer with more work but not syncing correctly with it.

@antiochp antiochp closed this as completed Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants